-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dialog): add config option for aria-describedby #5365
Conversation
I'm not sure this is right- what motivated this change? |
I ran into it while testing the dialog with NVDA where it doesn't read out the content at all. I based it on the example from MDN. |
In MDN's example, the element they're pointing to is literally a description of the dialog, though. In reality, that element will contain all sorts of arbitrary content, so it's not really accurate to say it's the AFAIK the content of the dialog would be available just like any other content on the page when navigating with a screenreader. How were you moving through the dialog after opening it? |
I tabbed my way to one of the buttons and opened the dialog. The dialog header got read out correctly, as well as the button, but none of the content. I also tried tabbing and clicking around, but I couldn't get it to read out anything. FWIW, VoiceOver works as it is in master. |
Typically you would use NVDA's navigation to go through text content (vs. jumping between form fields with tab). |
You're right, I retried it and it got read out this time. I'll re-purpose the PR to add a config option for |
Adds an option to the dialog config that allows for the `aria-describedby` to be set on the dialog container.
44cbb82
to
61e87ff
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds an option to the dialog config that allows for the `aria-describedby` to be set on the dialog container.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds an option to the dialog config that allows for the
aria-describedby
to be set on the dialog container.